Re: [PATCH v3 2/6] worktree.c: find_worktree() learns to identify worktrees by basename

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2016, 15:30 UTC
Message-ID: <xmqqoa7iqoh5.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACsJy8BF_KKXdMNW_aOs522wBbW9BQhbrZ_0hx+f2MCW-VPUzg@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

> basename() does (or I think so because Windows has its own version).
> worktree->path always uses '/' but the command line option can come
> with either '/' or '\'. Probably safest to accept both.

OK. Going beyond basename() was merely "This might be an easy nice-to-have enhancement", not "basename() is not sufficient because of such and such issues", so the patch is fine as-is.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.