Re: [PATCH v3 2/6] worktree.c: find_worktree() learns to identify worktrees by basename

> +static struct worktree *find_worktree_by_basename(struct worktree **list,
> +                                                 const char *base_name)
> +{
> +       struct worktree *found = NULL;
> +       int nr_found = 0;
> +
> +       for (; *list && nr_found < 2; list++) {
> +               char *path = xstrdup((*list)->path);
> +               if (!fspathcmp(base_name, basename(path))) {
> +                       found = *list;
> +                       nr_found++;
> +               }
> +               free(path);
> +       }
> +       return nr_found == 1 ? found : NULL;
> +}
>
>
>> If we always split at '/' boundary though (e.g. "abc/def/ghi",
>> "def/ghi" or "ghi" but never "ef/ghi") then it should be ok.
>
> Does "basename()" used here know '/' and '\' can both be a directory
> separator, or does worktree->path have a normalized representation
> of the path, i.e. '/' is the only directory separator?