Re: [PATCH v2 0/5] worktree lock/unlock

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 23, 2016, 04:51 UTC
Message-ID: <CAPig+cQVaMOKtbUCWdZqYDO8ZUZkVcSJH14S=2xrZiDVJ59Xdg@mail.gmail.com>
In-Reply-To: <20160522104341.656-1-pclouds@gmail.com>

On Sun, May 22, 2016 at 6:43 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

> This should address all of Eric's comments (thanks!). An extra change
> I made is free_worktrees() at the end of {,un}lock_worktree() to avoid
> leaking. This series depends on nd/worktree-cleanup-post-head-protection.

Thanks, this addresses all my comments from the previous round (aside from the suggestion to add a 'locked' field to 'struct worktree' and populate it automatically, which you elected to defer for the present).

I re-read the entire series and, aside from the typo in the documentation update of patch 4/5, everything looks fine, and the series is:

    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.