From: Junio C Hamano Date: Fri, 03 Jun 2016 15:30:30 GMT Subject: Re: [PATCH v3 2/6] worktree.c: find_worktree() learns to identify worktrees by basename Message-ID: In-Reply-To: Duy Nguyen writes: > basename() does (or I think so because Windows has its own version). > worktree->path always uses '/' but the command line option can come > with either '/' or '\'. Probably safest to accept both. OK. Going beyond basename() was merely "This might be an easy nice-to-have enhancement", not "basename() is not sufficient because of such and such issues", so the patch is fine as-is. Thanks.