Re: [PATCH v2 0/6] nd/worktree-cleanup-post-head-protection update

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 23, 2016, 01:09 UTC
Message-ID: <CAPig+cQ2NRO4yaFkcGmUpY3TZcWkdg-vu6d7Fq7JgHzYSkcRgg@mail.gmail.com>
In-Reply-To: <20160522093356.22389-1-pclouds@gmail.com>

On Sun, May 22, 2016 at 5:33 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 13 quoted lines

> This is mostly commit message update plus
>
>  - dropping "--force" from the completion patch (a comment from Szeder
>    Gabor in a previous attempt of worktree completion support).
>
>  - the removal of clear_worktree() patch.
>
> I keep the completion patch anyway even though two versions of it were
> posted by Eric and Szeder (and didn't get discussed much) because I
> needed this for new commands and because I didn't aim high. It's meant
> to provide very basic completion support. Fancy stuff like ref
> completion can be added later by people who are more experienced in
> bash completion stuff.

Thanks. Dropping the clear_worktree() patch does indeed seem like a good idea. I've re-read the entire series, and aside from my minor comments on 6/6, everything looks fine and the series is:

    Reviewed by: Eric Sunshine <sunshine@sunshineco.com>