Re: EOF test fixes (t5615/t7004)

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 22, 2017, 19:43 UTC
Message-ID: <xmqqo9wtjdvl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170322173528.ho43ulndlozq35tu@kalarepa>

Jan Palus <jan.palus@gmail.com> writes:

Show 25 quoted lines

> diff -ur git-2.12.0.orig/t/t7004-tag.sh git-2.12.0/t/t7004-tag.sh
> --- git-2.12.0.orig/t/t7004-tag.sh	2017-02-25 14:10:53.059367179 +0100
> +++ git-2.12.0/t/t7004-tag.sh	2017-02-25 14:11:45.105827700 +0100
> @@ -880,17 +880,17 @@
>  '
>  
>  test_expect_success 'verifying a proper tag with --format pass and format accordingly' '
> -	cat >expect <<-\EOF
> +	cat >expect <<-\EOF &&
>  	tagname : signed-tag
> -	EOF &&
> +	EOF
>  	git tag -v --format="tagname : %(tag)" "signed-tag" >actual &&
>  	test_cmp expect actual
>  '
>  
>  test_expect_success 'verifying a forged tag with --format fail and format accordingly' '
> -	cat >expect <<-\EOF
> +	cat >expect <<-\EOF &&
>  	tagname : forged-tag
> -	EOF &&
> +	EOF
>  	test_must_fail git tag -v --format="tagname : %(tag)" "forged-tag" >actual &&
>  	test_cmp expect actual
>  '

Ouch.  These shouldn't even have passed our review.

Thanks for spotting.