Re: [PATCH 3/3] t7004, t7030: fix here-doc syntax errors

From: Jeff King <peff@peff.net>
Date: Mar 24, 2017, 16:49 UTC
Message-ID: <20170324164943.7vvtcj5sqadj625o@sigill.intra.peff.net>
In-Reply-To: <xmqqlgru8vyt.fsf@gitster.mtv.corp.google.com>

On Fri, Mar 24, 2017 at 09:45:30AM -0700, Junio C Hamano wrote:

> I actually think this uncovers another class of breakage.  t7030
> tests should be protected with GPG prereq and 'fourth-signed' that
> is made only with the prereq in the first test will not be found.

It seems like t7030 should just skip_all when the GPG prereq is not met (it's not wrong to mark each test that's added, but it would have made this particular mistake harder).

> t7004 probably has the same issue.

These ones should be marked individually, though.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.