Re: [PATCH 3/3] t7004, t7030: fix here-doc syntax errors

From: Santiago Torres <santiago@nyu.edu>
Date: Mar 22, 2017, 21:43 UTC
Message-ID: <20170322214356.5jj7dggtvgilreci@LykOS.localdomain>
In-Reply-To: <20170322211003.b52cql3iwig2xqcd@sigill.intra.peff.net>

On Wed, Mar 22, 2017 at 05:10:03PM -0400, Jeff King wrote:

Show 17 quoted lines

> On Wed, Mar 22, 2017 at 01:08:05PM -0700, Junio C Hamano wrote:
> 
> > From: Jan Palus <jan.palus@gmail.com>
> > 
> > These all came as part of an earlier st/verify-tag topic that was
> > merged to 2.12.
> > 
> > Signed-off-by: Junio C Hamano <gitster@pobox.com>
> > ---
> > 
> >  * This should be applied on top of 4fea72f4 ("t/t7004-tag: Add
> >    --format specifier tests", 2017-01-17)
> > 
> >  t/t7004-tag.sh        | 8 ++++----
> >  t/t7030-verify-tag.sh | 8 ++++----
> >  2 files changed, 8 insertions(+), 8 deletions(-)
>

On my side, these patches make tests fail. I'm wondering if this is an issue with the underlying shell (probably the version)? Let me try to figure out what is exactly going on here.

> Like 2/3, this one also produces test failures for me. It looks like
> "verify-tag" does not show a tag which has been forged. I'm not sure if
> that's intentional (and the test is wrong) or a bug.

I see that offending code would be [1]. Changing this behavior should be trivial (dropping the continue), although I'm not sure if this is what we want?

> 
> -Peff

Thanks, -Santiago.

[1] https://github.com/git/git/blob/master/builtin/verify-tag.c#L6://github.com/git/git/blob/master/builtin/verify-tag.c#L67