Re: [PATCH 2/3] t7406: fix here-doc syntax errors
- From
Jeff King <peff@peff.net>
- Date
- Mar 22, 2017, 21:07 UTC
- Message-ID
- <20170322210733.ohb7duy7bmmon6ny@sigill.intra.peff.net>
- In-Reply-To
- <20170322200805.23837-3-gitster@pobox.com>
On Wed, Mar 22, 2017 at 01:08:04PM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> diff --git a/t/t7406-submodule-update.sh b/t/t7406-submodule-update.sh > index 347857fa7c..a20df9420a 100755 > --- a/t/t7406-submodule-update.sh > +++ b/t/t7406-submodule-update.sh > @@ -442,9 +442,9 @@ test_expect_success 'submodule update - command in .git/config catches failure - > ' > > test_expect_success 'submodule update - command run for initial population of submodule' ' > - cat <<-\ EOF >expect > + cat >expect <<-\EOF && > Execution of '\''false $submodulesha1'\'' failed in submodule path '\''submodule'\'' > - EOF && > + EOF
After applying this, I get a failure:
--- expect 2017-03-22 21:01:53.350721155 +0000 +++ actual 2017-03-22 21:01:53.346721155 +0000 @@ -1 +1 @@ -Execution of 'false $submodulesha1' failed in submodule path 'submodule' +Execution of 'false 4301fd3e4110d3b6212c19aed3094150392545b9' failed in submodule path '../submodule'
At the very least, we need to drop the "\" from EOF to expand $submodulesha1. But the submodule path seems wrong, too. I'm not sure if the expectation is wrong, or if there's a bug. +cc Stefan
-Peff