Re: [PATCH 2/3] t7406: fix here-doc syntax errors

From: Jeff King <peff@peff.net>
Date: Mar 22, 2017, 21:39 UTC
Message-ID: <20170322213953.oddbgw5nfrvmzjgm@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kafNKwfLhE1nXyt5mc5-D-kdxRxDP9pV7gc3btvjiHV7Q@mail.gmail.com>

On Wed, Mar 22, 2017 at 02:32:22PM -0700, Stefan Beller wrote:

Show 15 quoted lines

> > But the submodule path seems wrong, too. I'm not sure if
> > the expectation is wrong, or if there's a bug. +cc Stefan
> 
> Yes the actual output is wrong, too.
> But that is not because Git is wrong, but the test suite is.
> 
>     test_must_fail git -C super submodule update >../actual &&
> 
> contains 2 errors:
> 
> * we are interested in stderr, so make it 2>
> * the -C switch doesn't apply to redirection. (obviously!)
>   So if you have run the test suite in a normal setup, you may have
>   a file "t/actual" which is empty. This is scary as it managed to break
>   out of the test suite and overwrote a potential file in your git.git.

Oh yeah, I didn't even look at the test itself, but I see I now have t/actual in my repository. Yikes. That didn't happen before because it simply sucked the entire command into the here document.

> I'll send a patch on top of the one under discussion momentarily.

I'd prefer if they come in a single patch so that we don't break bisect.

-Peff