Re: [PATCH v5 0/3] align the behavior when opening "packed-refs"

From: Junio C Hamano <gitster@pobox.com>
Date: May 15, 2025, 12:57 UTC
Message-ID: <xmqqmsbe3uaw.fsf@gitster.g>
In-Reply-To: <aCS7O8tNekg_u9Wp@ArchLinux>

shejialuo <shejialuo@gmail.com> writes:

Show 12 quoted lines

> As discussed in [1], we need to use mmap mechanism to open large
> "packed_refs" file to save the memory usage. This patch mainly does the
> following things:
>
> 1: Fix an issue that we would report an error when the "packed-refs"
> file is empty, which does not align with the runtime behavior.
> 2-4: Extract some logic from the existing code and then use these
> created helper functions to let fsck code to use mmap necessarily
>
> [1] https://lore.kernel.org/git/20250503133158.GA4450@coredump.intra.peff.net
>
> Really thank Peff and Patrick to suggest me to do above change.

This round looks good to me.  Queued.  Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.