From: Junio C Hamano Date: Thu, 15 May 2025 12:57:59 GMT Subject: Re: [PATCH v5 0/3] align the behavior when opening "packed-refs" Message-ID: In-Reply-To: shejialuo writes: > As discussed in [1], we need to use mmap mechanism to open large > "packed_refs" file to save the memory usage. This patch mainly does the > following things: > > 1: Fix an issue that we would report an error when the "packed-refs" > file is empty, which does not align with the runtime behavior. > 2-4: Extract some logic from the existing code and then use these > created helper functions to let fsck code to use mmap necessarily > > [1] https://lore.kernel.org/git/20250503133158.GA4450@coredump.intra.peff.net > > Really thank Peff and Patrick to suggest me to do above change. This round looks good to me. Queued. Thanks.