Re: [PATCH 1/4] packed-backend: skip checking consistency of empty packed-refs file

From: shejialuo <shejialuo@gmail.com>
Date: May 7, 2025, 12:09 UTC
Message-ID: <aBtNhXVpnvPuV6b7@ArchLinux>
In-Reply-To: <xmqqr011k2ci.fsf@gitster.g>

On Tue, May 06, 2025 at 11:42:37AM -0700, Junio C Hamano wrote:

Show 16 quoted lines

> shejialuo <shejialuo@gmail.com> writes:
> 
> > +		touch .git/packed-refs &&
> 
> Unless you want to signal your readers that you care about file
> timestamp somehow, don't use "touch" as a means to create a file.
> Readers would have to wonder if .git/packed-refs existed before,
> or what git command that follows this part cares about its last
> modified time, or what behaviour the timestamp would affect.
> 
> What you are interested in doing with this is to ensure that *AN*
> *EMPTY* file exists there, hence you should say
> 
> 		>.git/packed-refs &&
> 
> instread.

Thanks for the suggestion, I didn't realise about this.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.