Re: [PATCH v7 0/3] Conditional config include
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 3, 2017, 23:22 UTC
- Message-ID
- <xmqqlgsm6j4k.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20170303222215.vwulypicszoh2hds@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Heh. I had no idea we had FREAD_READS_DIRECTORIES. I think Duy and I > reinvented it in another thread. ;)
You two were not alone. I was planning to reinvent it before I went to bed last night and then found it already was there this morning ;-)
> I agree that may be worth setting on Linux (though note that we _do_ > ignore other stdio read errors in the rest of the code path, which may > be something we want to address).
Yes, we need an error check on fopen() in git_config_from_file() regardless.