Re: [PATCH v7 0/3] Conditional config include
On Fri, Mar 03, 2017 at 01:33:29AM -0500, Jeff King wrote:
Show 10 quoted lines
> For those following on the mailing list, there is some discussion at:
>
> https://github.com/git/git/commit/484f78e46d00c6d35f20058671a8c76bb924fb33
>
> I think that is mostly focused around another failing in the
> error-handling of the config code, and that does not need to be
> addressed by this series (though of course I'd welcome any fixes).
>
> But there's a test failure that probably does need to be dealt with
> before this graduates to 'next'.
The patch to fix it is this
diff --git a/t/t1305-config-include.sh b/t/t1305-config-include.sh
index f0cd2056ba..e833939320 100755
--- a/t/t1305-config-include.sh
+++ b/t/t1305-config-include.sh
@@ -102,7 +102,7 @@ test_expect_success 'config modification does not affect includes' '
test_expect_success 'missing include files are ignored' '
cat >.gitconfig <<-\EOF &&
- [include]path = foo
+ [include]path = non-existent
[test]value = yes
EOF
echo yes >expect &&
Junio could you squash this in?
A lot more explanation is in another series [1] I just sent. Not sure
if we want to repeat the same in this commit's message.
And this series without that squash, when combined with [1], will fail
this test even on Linux. Good thing imo.
[1] http://public-inbox.org/git/20170303094252.11706-1-pclouds@gmail.com/
--
Duy
Duy Nguyen <pclouds@gmail.com>