From: Junio C Hamano Date: Fri, 03 Mar 2017 23:22:19 GMT Subject: Re: [PATCH v7 0/3] Conditional config include Message-ID: In-Reply-To: <20170303222215.vwulypicszoh2hds@sigill.intra.peff.net> Jeff King writes: > Heh. I had no idea we had FREAD_READS_DIRECTORIES. I think Duy and I > reinvented it in another thread. ;) You two were not alone. I was planning to reinvent it before I went to bed last night and then found it already was there this morning ;-) > I agree that may be worth setting on Linux (though note that we _do_ > ignore other stdio read errors in the rest of the code path, which may > be something we want to address). Yes, we need an error check on fopen() in git_config_from_file() regardless.