Re: [PATCH v7 1/3] config.txt: clarify multiple key values in include.path

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2017, 17:40 UTC
Message-ID: <xmqqshmwhp3q.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170301112631.16497-2-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 23 quoted lines

> The phrasing in this paragraph may give an impression that you can only
> use it once. Rephrase it a bit.
>
> Helped-by: Philip Oakley <philipoakley@iee.org>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  Documentation/config.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index 015346c417..4748efbf36 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -79,10 +79,10 @@ escape sequences) are invalid.
>  Includes
>  ~~~~~~~~
>  
> -You can include one config file from another by setting the special
> +You can include a config file from another by setting the special
>  `include.path` variable to the name of the file to be included. The
>  variable takes a pathname as its value, and is subject to tilde
> -expansion.
> +expansion. `include.path` supports multiple key values.

Multiple key values or just simply multiple values? I think it is the latter.

But to the intended target audience, I think

	`include.path` can be given multiple times.

is easier to understand. It's not like you can (or want to) enumerate with "git config --get-all include.path" to learn all the values (for the single key "include.value"), and it is better not to lead readers to think of this in terms of <key,value> in the first place (which is already clarified in the text that follows).

>  The
>  included file is expanded immediately, as if its contents had been