Re: [PATCH v6 1/1] config: add conditional include

From: Philip Oakley <philipoakley@iee.org>
Date: Feb 26, 2017, 12:28 UTC
Message-ID: <744E670407404147B290392DAD79DF44@PhilipOakley>
In-Reply-To: <CACsJy8Bq-P8Aw+f0omndCmQU54n_p7ZwDVDK9APuH_3vXDac2g@mail.gmail.com>

From: "Duy Nguyen" <pclouds@gmail.com>

Show 19 quoted lines

> On Sat, Feb 25, 2017 at 5:08 AM, Philip Oakley <philipoakley@iee.org> 
> wrote:
>>> +Conditional includes
>>> +~~~~~~~~~~~~~~~~~~~~
>>> +
>>> +You can include one config file from another conditionally by setting
>>
>>
>> On first reading I thought this implied you can only have one `includeIf`
>> within the config file.
>> I think it is meant to mean that each `includeIf`could include one other
>> file, and that users can have multiple `includeIf` lines.
>
> Yes. Not sure how to put it better though (I basically copied the
> first paragraph from the unconditional include section above, which
> shares the same confusion). Perhaps just write "the variable can be
> specified multiple times"? Or "multiple variables include multiple
> times, the last variable does not override the previous ones"?
> --

My attempt, based on updating the `Includes` section would be something like:

`You can include a config file from another by setting the special `include.path` variable to the name of the file to be included. The variable takes a pathname as its value, and is subject to tilde expansion. `include.path` supports multiple key values.`

The subtle change was to s/one/a/ at the start, and then add the final short sentence that states that the section's variables can have multiple key values.

I copied the 'multiple key values' phrase from the man page intro for consitency, though 'multivalued' could just as easily be used as it is the term used by the 'Configuration File' section that this is part of https://git-scm.com/docs/git-config#_configuration_file.

Even shorter may be: `You can include a config file from another by setting the special `include.path` variable to the name of the file to be included. The variable (can be multivalued) takes a pathname as its value, and is subject to tilde expansion.`

The Conditional Includes would follow suit.

Philip