Re: [PATCH v7 0/3] Conditional config include
- From
Jeff King <peff@peff.net>
- Date
- Mar 3, 2017, 06:33 UTC
- Message-ID
- <20170303063329.ji6do6eqjbpuwmxz@sigill.intra.peff.net>
- In-Reply-To
- <20170301112631.16497-1-pclouds@gmail.com>
On Wed, Mar 01, 2017 at 06:26:28PM +0700, Nguyễn Thái Ngọc Duy wrote:
> I don't have a good answer for Jeff's PS about includeIf ugliness. I > agree that includeif is ugly but includeIf looks a bit better. I don't > see a better option (if only "include" does not start or end with a > vowel...). Maybe includewith? Suggestions are welcome.
I actually think "include-if" _looks_ better, although maybe the inconsistency with "-" is something we don't want to encourage (though I also think the implicit include.<cond>.path was OK, too). Feel free to just ignore me. I will live with it either way.
For those following on the mailing list, there is some discussion at:
https://github.com/git/git/commit/484f78e46d00c6d35f20058671a8c76bb924fb33
I think that is mostly focused around another failing in the error-handling of the config code, and that does not need to be addressed by this series (though of course I'd welcome any fixes).
But there's a test failure that probably does need to be dealt with before this graduates to 'next'.
-Peff