Re: [PATCH v7 0/3] Conditional config include
- From
Jeff King <peff@peff.net>
- Date
- Mar 3, 2017, 22:22 UTC
- Message-ID
- <20170303222215.vwulypicszoh2hds@sigill.intra.peff.net>
- In-Reply-To
- <xmqqlgsm9q2i.fsf@gitster.mtv.corp.google.com>
On Fri, Mar 03, 2017 at 10:24:05AM -0800, Junio C Hamano wrote:
Show 16 quoted lines
> Jeff King <peff@peff.net> writes: > > > For those following on the mailing list, there is some discussion at: > > > > https://github.com/git/git/commit/484f78e46d00c6d35f20058671a8c76bb924fb33 > > > > I think that is mostly focused around another failing in the > > error-handling of the config code, and that does not need to be > > addressed by this series (though of course I'd welcome any fixes). > > Thanks. Without a message like this, the list may have never known > about the discussion taken elsewhere. I'd appreciate such a report > to appear on list the next time much earlier ;-) > > When built with FREAD_READS_DIRECTORIES=Yes on Linux, the error in > the test can easily reproduce.
Heh. I had no idea we had FREAD_READS_DIRECTORIES. I think Duy and I reinvented it in another thread. ;)
I agree that may be worth setting on Linux (though note that we _do_ ignore other stdio read errors in the rest of the code path, which may be something we want to address).
-Peff