Re: [PATCH v4 05/27] revision.[ch]: split freeing of revs->commit into a function
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 1, 2022, 17:03 UTC
- Message-ID
- <xmqqlewoybv3.fsf@gitster.g>
- In-Reply-To
- <e1bdb860-070b-8596-2a32-e9bc3ad354b0@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 6 quoted lines
>> +static void release_revisions_commit_list(struct rev_info *revs)
>> +{
>> + if (revs->commits) {
>
> This guard copied for the original is not needed, free_commit_list()
> will handle NULL just fine.Thanks for a careful reading.