Re: [PATCH v6 11/27] revisions API users: add "goto cleanup" for release_revisions()

From: Jeff King <peff@peff.net>
Date: Jul 12, 2022, 06:54 UTC
Message-ID: <Ys0at7pMPUrrmEaB@coredump.intra.peff.net>
In-Reply-To: <220711.86tu7n5ryf.gmgdl@evledraar.gmail.com>

On Mon, Jul 11, 2022 at 10:12:18PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 11 quoted lines

> > I was also somewhat confused by the double-assignment of "result" in the
> > cleanup label. But I think that is because diff_result_code() is
> > massaging the current value of "result" into the right thing. But in
> > that case, should the "-1" from earlier be passed to diff_result_code()?
> > I think probably not (and certainly it was not before your patch). Which
> > would imply that the label should go after that, like:
> [...]
> 
> Urgh, yes that's the obviously correct fix to bring it back to the
> previous behavior, it's indeed just a misplaced "cleanup" label, sorry
> about that.

Thanks, I'll work it up into a real patch. Which I should have just done in the first place; I just hadn't convinced myself I understood everything until I finished writing the other email. :)

-Peff