From: Junio C Hamano Date: Fri, 01 Apr 2022 17:03:44 GMT Subject: Re: [PATCH v4 05/27] revision.[ch]: split freeing of revs->commit into a function Message-ID: In-Reply-To: Phillip Wood writes: >> +static void release_revisions_commit_list(struct rev_info *revs) >> +{ >> + if (revs->commits) { > > This guard copied for the original is not needed, free_commit_list() > will handle NULL just fine. Thanks for a careful reading.