Re: [PATCH v5 00/27] revision.[ch]: add and use release_revisions()

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Apr 3, 2022, 14:18 UTC
Message-ID: <220403.861qyeme56.gmgdl@evledraar.gmail.com>
In-Reply-To: <5d3345d9-3c7c-a761-9c7a-03468a653e48@gmail.com>

On Sun, Apr 03 2022, Phillip Wood wrote:

Show 5 quoted lines

> Hi Ævar
>
> I've left a few comments on this series for the patches that I had not
> looked at in v4. There's nothing major, the changes mostly make sense
> to me (though I'm not familiar with the revisions api)

Thanks a lot. I'll re-roll a v6 in response, but will wait a bit for any other comments.

Show 13 quoted lines

> On 02/04/2022 11:49, Ævar Arnfjörð Bjarmason wrote:
>> This series reduces the memory leaks spotted by our tests by at least
>> half, see v3[1] for a more general overview.
>> Thanks a lot to Phillip Wood and Junio for the v4 review! I think
>> this
>> v5 should address all of the things brought up in v4 in one way or
>> another, changes:
>>   * The "extra_headers" or "ref_message_ids" freeing is the same,
>> but
>>     the commit message is altered to explain that commit.
>
> I'm still not that convinced that these are owned by the code in
> builtin/log.c but lets leave that for now.

Thanks.

> The rest of the changes
> look good. Thanks for working on this, when I use LSAN on my patches
> before submitting them I often see a lot of existing leaks coming from
> struct rev_info.

Yeah it'll become a lot more useful now.