Re: [PATCH v2 00/27] revision.[ch]: add and use release_revisions()

> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>
>> This is a re-roll of the v1 of [1] now that 7391ecd338e (Merge branch
>> 'ds/partial-bundles', 2022-03-21) has landed, which it had a conflict
>> with. I believe this v2 addresses all the feedback brought up on v1.
>
> Thanks.  It was mostly a pleasant read but with a huge caveat---I
> have no confidence in the code that would not try to release what it
> did not allocate (simply because I do not have time to audit all
> allocations to various members of rev-info structure).  But at least
> if we try to free something we borrowed from say command line, we'd
> immediately get a crash so with enough cooking and guinea-pig testing,
> such a bug would be easy to catch.

> I suspect cmd_show() still is leaky when fed a few commits.
> [...]
> There are ways to show different types of objects, but what we are
> interested in is what happens to commits.
>
>                     case OBJ_COMMIT:
>                             rev.pending.nr = rev.pending.alloc = 0;
>                             rev.pending.objects = NULL;