Re: [PATCH 09/18] fsck: handle multiple authors in commits specially

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 10, 2014, 18:04 UTC
Message-ID: <xmqqk31zidp5.fsf@gitster.dls.corp.google.com>
In-Reply-To: <43faa41d4cc98d6c40a393ec590af73ec5c94246.1418055173.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 8 quoted lines

> This problem has been detected in the wild, and is the primary reason
> to introduce an option to demote certain fsck errors to warnings. Let's
> offer to ignore this particular problem specifically.
> ...
> +	while (skip_prefix(buffer, "author ", &buffer)) {
> +		err = report(options, &commit->object, FSCK_MSG_MULTIPLE_AUTHORS, "invalid format - multiple 'author' lines");
> +		if (err)
> +			return err;

If we have an option to demote this to a warning, wouldn't we want to do the same fsck_ident() on that secondary author line?

Show 6 quoted lines

> +		/* require_end_of_header() ensured that there is a newline */
> +		buffer = strchr(buffer, '\n') + 1;
> +	}
>  	if (!skip_prefix(buffer, "committer ", &buffer))
>  		return report(options, &commit->object, FSCK_MSG_MISSING_COMMITTER, "invalid format - expected 'committer' line");
>  	err = fsck_ident(&buffer, &commit->object, options);