Re: [PATCH v2 04/18] fsck: Offer a function to demote fsck errors to warnings

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 21, 2015, 17:42 UTC
Message-ID: <40ed6b0223f660712004d3a040163f8d@www.dscho.org>
In-Reply-To: <xmqqppa8y0v4.fsf@gitster.dls.corp.google.com>

Hi Junio,

On 2015-01-21 09:49, Junio C Hamano wrote:

Show 11 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
>> +static inline int substrcmp(const char *string, int len, const char *match)
>> +{
>> +	int match_len = strlen(match);
>> +	if (match_len != len)
>> +		return -1;
>> +	return memcmp(string, match, len);
>> +}
> 
> Is this what we call "starts_with()" these days?

Unfortunately not quite: It really requires the substring specified by `string` and `len` to be identical to the full `match`. For example, `substrcmp("Hello world!", 5, "Hell")` would report a failure (because the substring "Hello" is *not* matching "Hell"), while `starts_with("Hello world!", "Hell")` would obviously succeed.

Show 9 quoted lines

>> +void fsck_set_severity(struct fsck_options *options, const char *mode)
>> +{
>> +	int severity = FSCK_ERROR;
>> +
>> +	if (!options->msg_severity) {
>> +		int i;
>> +		int *msg_severity = malloc(sizeof(int) * FSCK_MSG_MAX);
> 
> xmalloc()?

Absolutely! Fixed.

Thanks, Dscho