Re: [PATCH 12/18] Disallow demoting grave fsck errors to warnings

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 22, 2014, 21:56 UTC
Message-ID: <alpine.DEB.1.00.1412222254250.21312@s15462909.onlinehome-server.info>
In-Reply-To: <xmqqd27ridl0.fsf@gitster.dls.corp.google.com>

Hi Junio,

On Wed, 10 Dec 2014, Junio C Hamano wrote:

Show 9 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > Some kinds of errors are intrinsically unrecoverable (e.g. errors while
> > uncompressing objects). It does not make sense to allow demoting them to
> > mere warnings.
> 
> Makes sense, but the patch makes it look as if this is an "oops, we
> should have done the list in patch 02/18 in this order from the
> beginning".  Can we reorder the patches?

I considered this already, but it would more be like a squash than a reordering. And when I squashed the patches, the story did not read as clearly to me as it does now. However, if you think this argument is too weak, I will squash them.

Is it too weak?

Ciao, Dscho