Re: [PATCH v6 10/19] fsck: Make fsck_tag() warn-friendly

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 19, 2015, 21:06 UTC
Message-ID: <daaa8919802f7ace91cbc051bba6e42b@www.dscho.org>
In-Reply-To: <xmqqegl778pk.fsf@gitster.dls.corp.google.com>

Hi Junio,

On 2015-06-19 22:18, Junio C Hamano wrote:

Show 10 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
>> When fsck_tag() identifies a problem with the commit, it should try
>> to make it possible to continue checking the commit object, in case the
>> user wants to demote the detected errors to mere warnings.
> 
> I agree with that.  But if FSCK_MSG_BAD_OBJECT_SHA1 is an ignorable
> error, why should we still have a conditional "goto done" here?
> 
> Shouldn't we be parsing the object the same way regardless?

Same reason as I mentioned before: in `git receive-pack --strict` we want to fail early, there is no sense to keep going when we know that nothing of the rest will make it to the server.

Ciao, Dscho