Re: [PATCH 16/18] fsck: support demoting errors to warnings

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 23, 2014, 18:14 UTC
Message-ID: <alpine.DEB.1.00.1412231911470.21312@s15462909.onlinehome-server.info>
In-Reply-To: <xmqqsig62q78.fsf@gitster.dls.corp.google.com>

Hi Junio,

On Tue, 23 Dec 2014, Junio C Hamano wrote:

Show 6 quoted lines

> Having said that, I think "missingTags" etc. should not be configuration
> variable names (instead, they should be values).
> 
> Because of that, I do not think we need consistency between the way
> these "tokens that denote kinds of errors fsck denotes" are spelled and
> the way "configuration variable names" are spelled.

Okay. That makes more sense.

Now I can remove the complexity introduced by teaching the parser to accept camelCased values, and we're golden.

> In either case, I'd recommend that we take [ ,]+ as inter-token
> separator to ease the use on the command line and config file

And this is indeed the case:

+void fsck_strict_mode(struct fsck_options *options, const char *mode)
+...
+       while (*mode) {
+               int len = strcspn(mode, " ,|"), equal, msg_id;
+...

In other words, I even allowed the pipe symbol as separator.

Ciao, Dscho