git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v6 04/19] fsck: Offer a function to demote fsck errors to warnings

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 21, 2015, 18:47 UTC
Message-ID
<xmqq616gkiez.fsf@gitster.dls.corp.google.com>
In-Reply-To
<8545f1b636f157b280f15c615c1e1756@www.dscho.org>
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> How about I implement your suggestion tomorrow, then show the diff
> between the two versions and we can assess what looks to be simpler
> (i.e. more maintainable)?

I'm indifferent at this point, partly because as we agree that what you have as long as it works is ok, and more importantly, Michael's suggestion to turn "check unconditionally and only control if we ignore or warn or error out the result" into "do not even check if we are told to ignore" is a much more prouctive thing to spend your time on.

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 195 of 275 in “Introduce an internal API to interact with the fsck machinery”
  1. 00/18 Introduce an internal API to interact with the fsck machineryJohannes Schindelin, Dec 8, 2014
  2. 01/18 Introduce fsck optionsJohannes Schindelin, Dec 8, 2014
  3. Junio C HamanoDec 10, 2014
  4. Johannes SchindelinDec 22, 2014
  5. Junio C HamanoDec 22, 2014
  6. 02/18 Introduce identifiers for fsck messagesJohannes Schindelin, Dec 8, 2014
  7. 03/18 Provide a function to parse fsck message IDsJohannes Schindelin, Dec 8, 2014
  8. Junio C HamanoDec 10, 2014
  9. Johannes SchindelinDec 22, 2014
  10. 04/18 Offer a function to demote fsck errors to warningsJohannes Schindelin, Dec 8, 2014
  11. Junio C HamanoDec 10, 2014
  12. Johannes SchindelinDec 22, 2014
  13. Junio C HamanoDec 22, 2014
  14. Johannes SchindelinDec 22, 2014
  15. Junio C HamanoDec 22, 2014
  16. Johannes SchindelinDec 22, 2014
  17. Junio C HamanoDec 22, 2014
  18. Johannes SchindelinDec 23, 2014
  19. Junio C HamanoDec 23, 2014
  20. Johannes SchindelinDec 23, 2014
  21. Junio C HamanoDec 23, 2014
  22. Johannes SchindelinDec 23, 2014
  23. Junio C HamanoDec 23, 2014
  24. Johannes SchindelinDec 23, 2014
  25. 05/18 Allow demoting errors to warnings via receive.fsck.<key> = warnJohannes Schindelin, Dec 8, 2014
  26. Junio C HamanoDec 10, 2014
  27. Johannes SchindelinDec 22, 2014
  28. 06/18 fsck: report the ID of the error/warningJohannes Schindelin, Dec 8, 2014
  29. 07/18 Make fsck_ident() warn-friendlyJohannes Schindelin, Dec 8, 2014
  30. 08/18 Make fsck_commit() warn-friendlyJohannes Schindelin, Dec 8, 2014
  31. 09/18 fsck: handle multiple authors in commits speciallyJohannes Schindelin, Dec 8, 2014
  32. Junio C HamanoDec 10, 2014
  33. Johannes SchindelinDec 22, 2014
  34. 10/18 Make fsck_tag() warn-friendlyJohannes Schindelin, Dec 8, 2014
  35. 11/18 Add a simple test for receive.fsck.*Johannes Schindelin, Dec 8, 2014
  36. 12/18 Disallow demoting grave fsck errors to warningsJohannes Schindelin, Dec 8, 2014
  37. Junio C HamanoDec 10, 2014
  38. Johannes SchindelinDec 22, 2014
  39. 13/18 Optionally ignore specific fsck issues completelyJohannes Schindelin, Dec 8, 2014
  40. Junio C HamanoDec 10, 2014
  41. 14/18 fsck: allow upgrading fsck warnings to errorsJohannes Schindelin, Dec 8, 2014
  42. Junio C HamanoDec 10, 2014
  43. Johannes SchindelinDec 22, 2014
  44. Junio C HamanoDec 22, 2014
  45. Johannes SchindelinDec 22, 2014
  46. 15/18 Document the new receive.fsck.* options.Johannes Schindelin, Dec 8, 2014
  47. 16/18 fsck: support demoting errors to warningsJohannes Schindelin, Dec 8, 2014
  48. Junio C HamanoDec 10, 2014
  49. Johannes SchindelinDec 22, 2014
  50. Junio C HamanoDec 22, 2014
  51. Johannes SchindelinDec 22, 2014
  52. Junio C HamanoDec 22, 2014
  53. Johannes SchindelinDec 22, 2014
  54. Junio C HamanoDec 22, 2014
  55. Johannes SchindelinDec 23, 2014
  56. Junio C HamanoDec 23, 2014
  57. Johannes SchindelinDec 23, 2014
  58. Junio C HamanoDec 23, 2014
  59. Johannes SchindelinDec 23, 2014
  60. Junio C HamanoDec 23, 2014
  61. Johannes SchindelinDec 23, 2014
  62. Junio C HamanoDec 23, 2014
  63. Johannes SchindelinDec 23, 2014
  64. Junio C HamanoDec 23, 2014
  65. Johannes SchindelinDec 23, 2014
  66. Junio C HamanoDec 23, 2014
  67. Michael HaggertyJan 22, 2015
  68. Johannes SchindelinJan 22, 2015
  69. Johannes SchindelinJan 31, 2015
  70. Junio C HamanoDec 23, 2014
  71. 17/18 Introduce `git fsck --quick`Johannes Schindelin, Dec 8, 2014
  72. 18/18 git receive-pack: support excluding objects from fsck'ingJohannes Schindelin, Dec 8, 2014
  73. Junio C HamanoDec 10, 2014
  74. Johannes SchindelinDec 22, 2014
  75. Junio C HamanoDec 10, 2014
  76. 00/18 Introduce an internal API to interact with the fsck machineryJohannes Schindelin, Jan 19, 2015
  77. 01/18 fsck: Introduce fsck optionsJohannes Schindelin, Jan 19, 2015
  78. 02/18 fsck: Introduce identifiers for fsck messagesJohannes Schindelin, Jan 19, 2015
  79. 03/18 fsck: Provide a function to parse fsck message IDsJohannes Schindelin, Jan 19, 2015
  80. 04/18 fsck: Offer a function to demote fsck errors to warningsJohannes Schindelin, Jan 19, 2015
  81. Junio C HamanoJan 21, 2015
  82. Johannes SchindelinJan 21, 2015
  83. 05/18 fsck: Allow demoting errors to warnings via receive.fsck.warn = <key>Johannes Schindelin, Jan 19, 2015
  84. Junio C HamanoJan 21, 2015
  85. Johannes SchindelinJan 21, 2015
  86. Junio C HamanoJan 21, 2015
  87. Johannes SchindelinJan 22, 2015
  88. 06/18 fsck: Report the ID of the error/warningJohannes Schindelin, Jan 19, 2015
  89. 07/18 fsck: Make fsck_ident() warn-friendlyJohannes Schindelin, Jan 19, 2015
  90. Junio C HamanoJan 21, 2015
  91. 08/18 fsck: Make fsck_commit() warn-friendlyJohannes Schindelin, Jan 19, 2015
  92. 09/18 fsck: Handle multiple authors in commits speciallyJohannes Schindelin, Jan 19, 2015
  93. 10/18 fsck: Make fsck_tag() warn-friendlyJohannes Schindelin, Jan 19, 2015
  94. 11/18 fsck: Add a simple test for receive.fsck.*Johannes Schindelin, Jan 19, 2015
  95. Junio C HamanoJan 21, 2015
  96. Johannes SchindelinJan 21, 2015
  97. 12/18 fsck: Disallow demoting grave fsck errors to warningsJohannes Schindelin, Jan 19, 2015
  98. 13/18 fsck: Optionally ignore specific fsck issues completelyJohannes Schindelin, Jan 19, 2015
  99. 14/18 fsck: Allow upgrading fsck warnings to errorsJohannes Schindelin, Jan 19, 2015
  100. 15/18 fsck: Document the new receive.fsck.* options.Johannes Schindelin, Jan 19, 2015
  101. Eric SunshineJan 19, 2015
  102. Johannes SchindelinJan 20, 2015
  103. 16/18 fsck: Support demoting errors to warningsJohannes Schindelin, Jan 19, 2015
  104. 17/18 fsck: Introduce `git fsck --quick`Johannes Schindelin, Jan 19, 2015
  105. 18/18 fsck: git receive-pack: support excluding objects from fsck'ingJohannes Schindelin, Jan 19, 2015
  106. Junio C HamanoJan 21, 2015
  107. Johannes SchindelinJan 21, 2015
  108. Junio C HamanoJan 21, 2015
  109. Johannes SchindelinJan 21, 2015
  110. 00/19 Introduce an internal API to interact with the fsck machineryJohannes Schindelin, Jan 21, 2015
  111. 01/19 fsck: Introduce fsck optionsJohannes Schindelin, Jan 21, 2015
  112. 02/19 fsck: Introduce identifiers for fsck messagesJohannes Schindelin, Jan 21, 2015
  113. 03/19 fsck: Provide a function to parse fsck message IDsJohannes Schindelin, Jan 21, 2015
  114. 04/19 fsck: Offer a function to demote fsck errors to warningsJohannes Schindelin, Jan 21, 2015
  115. 05/19 fsck: Allow demoting errors to warnings via receive.fsck.warn = <key>Johannes Schindelin, Jan 21, 2015
  116. 06/19 fsck: Report the ID of the error/warningJohannes Schindelin, Jan 21, 2015
  117. 07/19 fsck: Make fsck_ident() warn-friendlyJohannes Schindelin, Jan 21, 2015
  118. 08/19 fsck: Make fsck_commit() warn-friendlyJohannes Schindelin, Jan 21, 2015
  119. 09/19 fsck: Handle multiple authors in commits speciallyJohannes Schindelin, Jan 21, 2015
  120. 10/19 fsck: Make fsck_tag() warn-friendlyJohannes Schindelin, Jan 21, 2015
  121. 11/19 fsck: Add a simple test for receive.fsck.*Johannes Schindelin, Jan 21, 2015
  122. 12/19 fsck: Disallow demoting grave fsck errors to warningsJohannes Schindelin, Jan 21, 2015
  123. 13/19 fsck: Optionally ignore specific fsck issues completelyJohannes Schindelin, Jan 21, 2015
  124. 14/19 fsck: Allow upgrading fsck warnings to errorsJohannes Schindelin, Jan 21, 2015
  125. 15/19 fsck: Document the new receive.fsck.* options.Johannes Schindelin, Jan 21, 2015
  126. 16/19 fsck: Support demoting errors to warningsJohannes Schindelin, Jan 21, 2015
  127. 17/19 fsck: Introduce `git fsck --quick`Johannes Schindelin, Jan 21, 2015
  128. 18/19 fsck: git receive-pack: support excluding objects from fsck'ingJohannes Schindelin, Jan 21, 2015
  129. 19/19 fsck: support ignoring objects in `git fsck` via fsck.skiplistJohannes Schindelin, Jan 21, 2015
  130. 00/19 Introduce an internal API to interact with the fsck machineryJohannes Schindelin, Jan 31, 2015
  131. 01/19 fsck: Introduce fsck optionsJohannes Schindelin, Jan 31, 2015
  132. 02/19 fsck: Introduce identifiers for fsck messagesJohannes Schindelin, Jan 31, 2015
  133. 03/19 fsck: Provide a function to parse fsck message IDsJohannes Schindelin, Jan 31, 2015
  134. 05/19 fsck: Allow demoting errors to warningsJohannes Schindelin, Jan 31, 2015
  135. 04/19 fsck: Offer a function to demote fsck errors to warningsJohannes Schindelin, Jan 31, 2015
  136. 11/19 fsck: Add a simple test for receive.fsck.severityJohannes Schindelin, Jan 31, 2015
  137. 12/19 fsck: Disallow demoting grave fsck errors to warningsJohannes Schindelin, Jan 31, 2015
  138. 07/19 fsck: Make fsck_ident() warn-friendlyJohannes Schindelin, Jan 31, 2015
  139. 08/19 fsck: Make fsck_commit() warn-friendlyJohannes Schindelin, Jan 31, 2015
  140. 10/19 fsck: Make fsck_tag() warn-friendlyJohannes Schindelin, Jan 31, 2015
  141. 15/19 fsck: Document the new receive.fsck.severity options.Johannes Schindelin, Jan 31, 2015
  142. 09/19 fsck: Handle multiple authors in commits speciallyJohannes Schindelin, Jan 31, 2015
  143. 14/19 fsck: Allow upgrading fsck warnings to errorsJohannes Schindelin, Jan 31, 2015
  144. 06/19 fsck: Report the ID of the error/warningJohannes Schindelin, Jan 31, 2015
  145. 13/19 fsck: Optionally ignore specific fsck issues completelyJohannes Schindelin, Jan 31, 2015
  146. 16/19 fsck: Support demoting errors to warningsJohannes Schindelin, Jan 31, 2015
  147. 17/19 fsck: Introduce `git fsck --quick`Johannes Schindelin, Jan 31, 2015
  148. 18/19 fsck: git receive-pack: support excluding objects from fsck'ingJohannes Schindelin, Jan 31, 2015
  149. 19/19 fsck: support ignoring objects in `git fsck` via fsck.skiplistJohannes Schindelin, Jan 31, 2015
  150. Johannes SchindelinFeb 2, 2015
  151. Michael HaggertyFeb 2, 2015
  152. Johannes SchindelinFeb 2, 2015
  153. Michael HaggertyFeb 3, 2015
  154. Johannes SchindelinFeb 3, 2015
  155. Junio C HamanoFeb 4, 2015
  156. Johannes SchindelinFeb 4, 2015
  157. 00/19 Introduce an internal API to interact with the fsck machineryJohannes Schindelin, Jun 18, 2015
  158. 01/19 fsck: Introduce fsck optionsJohannes Schindelin, Jun 18, 2015
  159. 02/19 fsck: Introduce identifiers for fsck messagesJohannes Schindelin, Jun 18, 2015
  160. 03/19 fsck: Provide a function to parse fsck message IDsJohannes Schindelin, Jun 18, 2015
  161. 04/19 fsck: Offer a function to demote fsck errors to warningsJohannes Schindelin, Jun 18, 2015
  162. 05/19 fsck (receive-pack): Allow demoting errors to warningsJohannes Schindelin, Jun 18, 2015
  163. 06/19 fsck: Report the ID of the error/warningJohannes Schindelin, Jun 18, 2015
  164. 07/19 fsck: Make fsck_ident() warn-friendlyJohannes Schindelin, Jun 18, 2015
  165. 08/19 fsck: Make fsck_commit() warn-friendlyJohannes Schindelin, Jun 18, 2015
  166. 09/19 fsck: Handle multiple authors in commits speciallyJohannes Schindelin, Jun 18, 2015
  167. 11/19 fsck: Add a simple test for receive.fsck.<msg-id>Johannes Schindelin, Jun 18, 2015
  168. 10/19 fsck: Make fsck_tag() warn-friendlyJohannes Schindelin, Jun 18, 2015
  169. 12/19 fsck: Disallow demoting grave fsck errors to warningsJohannes Schindelin, Jun 18, 2015
  170. 13/19 fsck: Optionally ignore specific fsck issues completelyJohannes Schindelin, Jun 18, 2015
  171. 14/19 fsck: Allow upgrading fsck warnings to errorsJohannes Schindelin, Jun 18, 2015
  172. 15/19 fsck: Document the new receive.fsck.<msg-id> optionsJohannes Schindelin, Jun 18, 2015
  173. 16/19 fsck: Support demoting errors to warningsJohannes Schindelin, Jun 18, 2015
  174. 17/19 fsck: Introduce `git fsck --quick`Johannes Schindelin, Jun 18, 2015
  175. 18/19 fsck: git receive-pack: support excluding objects from fsck'ingJohannes Schindelin, Jun 18, 2015
  176. 19/19 fsck: support ignoring objects in `git fsck` via fsck.skiplistJohannes Schindelin, Jun 18, 2015
  177. Junio C HamanoJun 18, 2015
  178. Johannes SchindelinJun 19, 2015
  179. Junio C HamanoJun 19, 2015
  180. Johannes SchindelinJun 19, 2015
  181. 00/19 Introduce an internal API to interact with the fsck machineryJohannes Schindelin, Jun 19, 2015
  182. 01/19 fsck: Introduce fsck optionsJohannes Schindelin, Jun 19, 2015
  183. Junio C HamanoJun 19, 2015
  184. Johannes SchindelinJun 20, 2015
  185. 02/19 fsck: Introduce identifiers for fsck messagesJohannes Schindelin, Jun 19, 2015
  186. Junio C HamanoJun 19, 2015
  187. 03/19 fsck: Provide a function to parse fsck message IDsJohannes Schindelin, Jun 19, 2015
  188. Junio C HamanoJun 19, 2015
  189. Johannes SchindelinJun 21, 2015
  190. 04/19 fsck: Offer a function to demote fsck errors to warningsJohannes Schindelin, Jun 19, 2015
  191. Junio C HamanoJun 19, 2015
  192. Johannes SchindelinJun 21, 2015
  193. Junio C HamanoJun 21, 2015
  194. Johannes SchindelinJun 21, 2015
  195. Junio C HamanoJun 21, 2015
  196. Johannes SchindelinJun 22, 2015
  197. 05/19 fsck (receive-pack): Allow demoting errors to warningsJohannes Schindelin, Jun 19, 2015
  198. 06/19 fsck: Report the ID of the error/warningJohannes Schindelin, Jun 19, 2015
  199. Junio C HamanoJun 19, 2015
  200. Johannes SchindelinJun 19, 2015
  201. Junio C HamanoJun 19, 2015
  202. 07/19 fsck: Make fsck_ident() warn-friendlyJohannes Schindelin, Jun 19, 2015
  203. Junio C HamanoJun 19, 2015
  204. 08/19 fsck: Make fsck_commit() warn-friendlyJohannes Schindelin, Jun 19, 2015
  205. Junio C HamanoJun 19, 2015
  206. Johannes SchindelinJun 19, 2015
  207. Junio C HamanoJun 19, 2015
  208. Junio C HamanoJun 19, 2015
  209. 09/19 fsck: Handle multiple authors in commits speciallyJohannes Schindelin, Jun 19, 2015
  210. Junio C HamanoJun 19, 2015
  211. Johannes SchindelinJun 19, 2015
  212. 10/19 fsck: Make fsck_tag() warn-friendlyJohannes Schindelin, Jun 19, 2015
  213. Junio C HamanoJun 19, 2015
  214. Johannes SchindelinJun 19, 2015
  215. 11/19 fsck: Add a simple test for receive.fsck.<msg-id>Johannes Schindelin, Jun 19, 2015
  216. 12/19 fsck: Disallow demoting grave fsck errors to warningsJohannes Schindelin, Jun 19, 2015
  217. Junio C HamanoJun 19, 2015
  218. Johannes SchindelinJun 19, 2015
  219. Junio C HamanoJun 19, 2015
  220. 13/19 fsck: Optionally ignore specific fsck issues completelyJohannes Schindelin, Jun 19, 2015
  221. 14/19 fsck: Allow upgrading fsck warnings to errorsJohannes Schindelin, Jun 19, 2015
  222. Junio C HamanoJun 19, 2015
  223. Johannes SchindelinJun 19, 2015
  224. 15/19 fsck: Document the new receive.fsck.<msg-id> optionsJohannes Schindelin, Jun 19, 2015
  225. 16/19 fsck: Support demoting errors to warningsJohannes Schindelin, Jun 19, 2015
  226. 17/19 fsck: Introduce `git fsck --quick`Johannes Schindelin, Jun 19, 2015
  227. Junio C HamanoJun 19, 2015
  228. Johannes SchindelinJun 19, 2015
  229. Junio C HamanoJun 19, 2015
  230. Scott SchmitJun 19, 2015
  231. Junio C HamanoJun 20, 2015
  232. Michael HaggertyJun 21, 2015
  233. Randall S. BeckerJun 21, 2015
  234. Johannes SchindelinJun 21, 2015
  235. Johannes SchindelinJun 21, 2015
  236. Junio C HamanoJun 21, 2015
  237. Johannes SchindelinJun 21, 2015
  238. Junio C HamanoJun 21, 2015
  239. Junio C HamanoJun 21, 2015
  240. Johannes SchindelinJun 22, 2015
  241. Junio C HamanoJun 20, 2015
  242. 18/19 fsck: git receive-pack: support excluding objects from fsck'ingJohannes Schindelin, Jun 19, 2015
  243. Junio C HamanoJun 19, 2015
  244. Johannes SchindelinJun 20, 2015
  245. Junio C HamanoJun 20, 2015
  246. Junio C HamanoJun 22, 2015
  247. Johannes SchindelinJun 22, 2015
  248. 19/19 fsck: support ignoring objects in `git fsck` via fsck.skiplistJohannes Schindelin, Jun 19, 2015
  249. Junio C HamanoJun 19, 2015
  250. 00/19 Introduce an internal API to interact with the fsck machineryJohannes Schindelin, Jun 22, 2015
  251. 01/19 fsck: Introduce fsck optionsJohannes Schindelin, Jun 22, 2015
  252. 02/19 fsck: Introduce identifiers for fsck messagesJohannes Schindelin, Jun 22, 2015
  253. 03/19 fsck: Provide a function to parse fsck message IDsJohannes Schindelin, Jun 22, 2015
  254. 04/19 fsck: Offer a function to demote fsck errors to warningsJohannes Schindelin, Jun 22, 2015
  255. Junio C HamanoJun 22, 2015
  256. Johannes SchindelinJun 22, 2015
  257. 05/19 fsck (receive-pack): Allow demoting errors to warningsJohannes Schindelin, Jun 22, 2015
  258. 06/19 fsck: Report the ID of the error/warningJohannes Schindelin, Jun 22, 2015
  259. 07/19 fsck: Make fsck_ident() warn-friendlyJohannes Schindelin, Jun 22, 2015
  260. 08/19 fsck: Make fsck_commit() warn-friendlyJohannes Schindelin, Jun 22, 2015
  261. 09/19 fsck: Handle multiple authors in commits speciallyJohannes Schindelin, Jun 22, 2015
  262. 10/19 fsck: Make fsck_tag() warn-friendlyJohannes Schindelin, Jun 22, 2015
  263. 11/19 fsck: Add a simple test for receive.fsck.<msg-id>Johannes Schindelin, Jun 22, 2015
  264. 12/19 fsck: Disallow demoting grave fsck errors to warningsJohannes Schindelin, Jun 22, 2015
  265. 13/19 fsck: Optionally ignore specific fsck issues completelyJohannes Schindelin, Jun 22, 2015
  266. Junio C HamanoJun 22, 2015
  267. Johannes SchindelinJun 22, 2015
  268. 14/19 fsck: Allow upgrading fsck warnings to errorsJohannes Schindelin, Jun 22, 2015
  269. 15/19 fsck: Document the new receive.fsck.<msg-id> optionsJohannes Schindelin, Jun 22, 2015
  270. 16/19 fsck: Support demoting errors to warningsJohannes Schindelin, Jun 22, 2015
  271. 17/19 fsck: Introduce `git fsck --connectivity-only`Johannes Schindelin, Jun 22, 2015
  272. 18/19 fsck: git receive-pack: support excluding objects from fsck'ingJohannes Schindelin, Jun 22, 2015
  273. 19/19 fsck: support ignoring objects in `git fsck` via fsck.skiplistJohannes Schindelin, Jun 22, 2015
  274. Junio C HamanoJun 22, 2015
  275. Johannes SchindelinJun 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.