Re: [PATCH v6 14/19] fsck: Allow upgrading fsck warnings to errors

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 19, 2015, 20:22 UTC
Message-ID: <xmqq616j78ik.fsf@gitster.dls.corp.google.com>
In-Reply-To: <49189b5b9e8ad194c6408b30db6f493c53595021.1434720655.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

Show 22 quoted lines

>  #define FSCK_FATAL -1
> +#define FSCK_INFO -2
>  
>  #define FOREACH_MSG_ID(FUNC) \
>  	/* fatal errors */ \
> @@ -50,15 +51,16 @@
>  	FUNC(ZERO_PADDED_DATE, ERROR) \
>  	/* warnings */ \
>  	FUNC(BAD_FILEMODE, WARN) \
> -	FUNC(BAD_TAG_NAME, WARN) \
>  	FUNC(EMPTY_NAME, WARN) \
>  	FUNC(FULL_PATHNAME, WARN) \
>  	FUNC(HAS_DOT, WARN) \
>  	FUNC(HAS_DOTDOT, WARN) \
>  	FUNC(HAS_DOTGIT, WARN) \
> -	FUNC(MISSING_TAGGER_ENTRY, WARN) \
>  	FUNC(NULL_SHA1, WARN) \
> -	FUNC(ZERO_PADDED_FILEMODE, WARN)
> +	FUNC(ZERO_PADDED_FILEMODE, WARN) \
> +	/* infos (reported as warnings, but ignored by default) */ \
> +	FUNC(BAD_TAG_NAME, INFO) \
> +	FUNC(MISSING_TAGGER_ENTRY, INFO)

Exactly the same comment as 12/19 applies to this change; not only complaints but also "result makes sense" part.