Re: [PATCH 2/2] difftool: add a feature flag for the builtin vs scripted version
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 23, 2016, 18:18 UTC
- Message-ID
- <xmqqd1hmm54f.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqh96ym6x6.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 5 quoted lines
> Can't you route the control upon seeing "git difftool" to your > experimental "C" difftool and check the configuration there? Then > you can decide to run_command() a non-builtin one depending what the > configuration says---that way, you would incur cost of spawning Perl > only when you need it, no?
FWIW, the approach taken by 73c2779f42 ("builtin-am: implement skeletal builtin am", 2015-08-04) is what I had in mind when I wrote the above.