Re: [PATCH v5 3/3] Retire the scripted difftool
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 19, 2017, 16:30 UTC
- Message-ID
- <alpine.DEB.2.20.1701191730040.3469@virtualbox>
- In-Reply-To
- <xmqqbmv49o3s.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 18 Jan 2017, Junio C Hamano wrote:
Show 33 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > Hi Junio, > > > > On Tue, 17 Jan 2017, Junio C Hamano wrote: > > > >> Johannes Schindelin <johannes.schindelin@gmx.de> writes: > >> > >> > It served its purpose, but now we have a builtin difftool. Time for the > >> > Perl script to enjoy Florida. > >> > > >> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > >> > --- > >> > >> The endgame makes a lot of sense. Both in the cover letter and in > >> the previous patch you talk about having both in the released > >> version, so do you want this step to proceed slower than the other > >> two? > > > > I did proceed that slowly. Already three Git for Windows versions have > > been released with both. > > > > But I submitted this iteration with this patch, so my intent is clearly to > > retire the Perl script. > > Ok, I was mostly reacting to 2/3 while I am reading it: > > The reason: this new, experimental, builtin difftool will be shipped as > part of Git for Windows v2.11.0, to allow for easier large-scale > testing, but of course as an opt-in feature. > > as there is no longer an opportunity to participate in this opt-in > testing, unless 3/3 is special cased and delayed.
Yep, as Git for Windows v2.11.0 is yesteryear's news, it was probably obvious to you that I simply failed to spot and fix that oversight.
Ciao, Johannes