Re: [PATCH v3 1/2] difftool: add a skeleton for the upcoming builtin
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 25, 2016, 17:41 UTC
- Message-ID
- <alpine.DEB.2.20.1611251841030.117539@virtualbox>
- In-Reply-To
- <20161125171940.rizbqyhsygdsoujr@sigill.intra.peff.net>
Hi Peff,
On Fri, 25 Nov 2016, Jeff King wrote:
Show 18 quoted lines
> On Fri, Nov 25, 2016 at 12:05:00PM +0100, Johannes Schindelin wrote: > > > > I would have expected it to just be a build-time flag, like: > > > > > > make BUILTIN_DIFFTOOL=Yes test > > > > That works for Git developers. > > > > I want to let as many users as possible test the builtin difftool. > > Hopefully a lot more users than there are Git developers. > > > > Which means that I need a feature flag in production code, not a build > > time flag. > > Ah, I didn't realize that was a requirement. If this is going to be part > of a release and real end-users are going to see it, that does make me > think the config option is the better path (than the presence of some > file), as it's our standard way of tweaking run-time behavior.
So how do you easily switch back and forth between testing the old vs the new difftool via the test suite?
Ciao, Dscho