Re: [PATCH v3 1/2] difftool: add a skeleton for the upcoming builtin

From: Jeff King <peff@peff.net>
Date: Nov 27, 2016, 16:50 UTC
Message-ID: <20161127165058.uxujjehyjq7httro@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.2.20.1611261400300.117539@virtualbox>

On Sat, Nov 26, 2016 at 02:01:36PM +0100, Johannes Schindelin wrote:

Show 9 quoted lines

> > If you want to control it from outside the test script, you'd need
> > something like:
> > 
> >   if test "$GIT_TEST_DIFFTOOL" = "builtin"
> 
> That is a bit magic. I first used "GIT_USE_BUILTIN_DIFFTOOL" and it did
> not work. My name is arguably more correct (see also Jakub's note about
> "naming is hard"), but yours works because there is a "TEST" substring in
> it.

Yes. You are free to add an exception to the env list in test-lib.sh, but we usually use GIT_TEST_* to avoid having to do so.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.