Re: [PATCH v3 1/2] difftool: add a skeleton for the upcoming builtin

From: Jeff King <peff@peff.net>
Date: Nov 30, 2016, 12:35 UTC
Message-ID: <20161130123538.pydczcx6rbth7ng7@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.2.20.1611301330100.117539@virtualbox>

On Wed, Nov 30, 2016 at 01:30:47PM +0100, Johannes Schindelin wrote:

Show 16 quoted lines

> On Tue, 29 Nov 2016, Jeff King wrote:
> 
> > On Tue, Nov 29, 2016 at 09:36:55PM +0100, Johannes Schindelin wrote:
> > 
> > > So the suggestion by both you and Peff, to use an environment variable,
> > > which is either global, or requires the user to set it manually per
> > > session, is simply not a good idea at all.
> > 
> > No, my suggestion was to use config and have the test suite use an
> > environment variable to test both cases (preferably automatically,
> > without the user having to do anything).
> > 
> > I do not see how that fails to cover all of your use cases.
> 
> Oh, so the suggestion is to have *both* a config *and* an environment
> variable. That is not elegant.

No, that is not at all what I said. I was going to explain myself again, but I do not see what good it would do, as clearly my point did not come across in the other three emails. And then you would just complain that I am making work for you. So whatever. I do not care about your difftool topic at all. Do whatever you like (which hey, I already said before, too).

-Peff