Re: [PATCH v4 1/4] Avoid Coverity warning about unfree()d git_exec_path()

From: Stefan Beller <sbeller@google.com>
Date: Jan 9, 2017, 19:21 UTC
Message-ID: <CAGZ79ka0+=om_iWyALCZcK502oU9vCFsZG15ktsN6MxkwKTN-w@mail.gmail.com>
In-Reply-To: <xmqqy3ylyqhf.fsf@gitster.mtv.corp.google.com>

On Sun, Jan 8, 2017 at 5:25 PM, Junio C Hamano <gitster@pobox.com> wrote:

> So with the above, are you saying "Dscho said 'hopefully', and I
> confirm that this change does squelch misdiagnosis by Coverity"?

I could not find the coverity issue any more. (It really misses easy access to "recently fixed" problems)

Show 13 quoted lines

> commit c9bb5d101ca657fa466afa8c4368c43ea7b7aca8
> Author: Johannes Schindelin <johannes.schindelin@gmx.de>
> Date:   Mon Jan 2 17:22:33 2017 +0100
>
>     git_exec_path: avoid Coverity warning about unfree()d result
>
>     Technically, it is correct that git_exec_path() returns a possibly
>     malloc()ed string returned from system_path(), and it is sometimes
>     not allocated.  Cache the result in a static variable and make sure
>     that we call system_path() only once, which plugs a potential leak.
>
>     Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>     Signed-off-by: Junio C Hamano <gitster@pobox.com>

Sounds good to me,

Thanks, Stefan