Re: [PATCH v5 3/3] Retire the scripted difftool

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 18, 2017, 19:15 UTC
Message-ID: <xmqqbmv49o3s.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1701181332230.3469@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 22 quoted lines

> Hi Junio,
>
> On Tue, 17 Jan 2017, Junio C Hamano wrote:
>
>> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>> 
>> > It served its purpose, but now we have a builtin difftool. Time for the
>> > Perl script to enjoy Florida.
>> >
>> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> > ---
>> 
>> The endgame makes a lot of sense.  Both in the cover letter and in
>> the previous patch you talk about having both in the released
>> version, so do you want this step to proceed slower than the other
>> two?
>
> I did proceed that slowly. Already three Git for Windows versions have
> been released with both.
>
> But I submitted this iteration with this patch, so my intent is clearly to
> retire the Perl script.

Ok, I was mostly reacting to 2/3 while I am reading it:

    The reason: this new, experimental, builtin difftool will be shipped as
    part of Git for Windows v2.11.0, to allow for easier large-scale
    testing, but of course as an opt-in feature.

as there is no longer an opportunity to participate in this opt-in testing, unless 3/3 is special cased and delayed.