Re: [PATCH v4 7/9] sequencer: load commit related config

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 24, 2017, 13:48 UTC
Message-ID: <xmqqbmjrn5yb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171124110758.9406-8-phillip.wood@talktalk.net>

Phillip Wood <phillip.wood@talktalk.net> writes:

Show 6 quoted lines

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> Load default values for message cleanup and gpg signing of commits in
> preparation for committing without forking 'git commit'. Note that we
> interpret commit.cleanup=scissors to mean COMMIT_MSG_CLEANUP_SPACE to
> be consistent with 'git commit'

Hmph, is that because we never invoke the editor to edit the commit log message? Over there, scissors is demoted to space when the editor is not in use, but otherwise this demotion does not occur.

Just being curious.

Show 8 quoted lines

>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> ---
>
> Notes:
>     changes since v3:
>      - interpret commit.cleanup=scissors to mean COMMIT_MSG_CLEANUP_SPACE
>        to match 'git commit'