Re: [PATCH v2 2/9] commit: move empty message checks to libgit
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Nov 10, 2017, 18:51 UTC
- Message-ID
- <dbdb4990-e539-42d5-df0a-3d5f4a993faf@ramsayjones.plus.com>
- In-Reply-To
- <20171110110949.328-3-phillip.wood@talktalk.net>
On 10/11/17 11:09, Phillip Wood wrote:
Show 19 quoted lines
> From: Phillip Wood <phillip.wood@dunelm.org.uk> > > Move the functions that check for empty messages from bulitin/commit.c > to sequencer.c so they can be shared with other commands. The > functions are refactored to take an explicit cleanup mode and template > filename passed by the caller. > > Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk> > --- > > Notes: > changes since v1: > - prefix cleanup_mode enum and constants with commit_msg_ > > builtin/commit.c | 99 +++++++++++--------------------------------------------- > sequencer.c | 61 ++++++++++++++++++++++++++++++++++ > sequencer.h | 11 +++++++ > 3 files changed, 91 insertions(+), 80 deletions(-) >
Just an idle thought - why are these functions moving to sequencer.[ch] rather than commit[.ch]?
Similar comments for other patches in the series which moves code from builtin/commit.c to sequencer.[ch].
ATB, Ramsay Jones