Re: [PATCH v5 8/9] sequencer: try to commit without forking 'git commit'

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 10, 2018, 20:53 UTC
Message-ID: <20180110205351.GA73826@aiede.svl.corp.google.com>
In-Reply-To: <20171211141330.23566-9-phillip.wood@talktalk.net>

Hi,

Phillip Wood wrote:

Show 10 quoted lines

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> If the commit message does not need to be edited then create the
> commit without forking 'git commit'. Taking the best time of ten runs
> with a warm cache this reduces the time taken to cherry-pick 10
> commits by 27% (from 282ms to 204ms), and the time taken by 'git
> rebase --continue' to pick 10 commits by 45% (from 386ms to 212ms) on
> my computer running linux. Some of greater saving for rebase is
> because it no longer wastes time creating the commit summary just to
> throw it away.

Neat! Dmitry Torokhov (cc-ed) noticed[1] that this causes the prepare-commit-msg hook not to be invoked, which I think is unintentional. Should we check for such a hook and take the slowpath when it is present?

Thanks, Jonathan

[1] https://public-inbox.org/git/CAKdAkRQuj1hfKeckjuR2oP+8C1i+ZR36O-+aRYif4ufaS_zs+w@mail.gmail.com/