Re: [PATCH v4 7/9] sequencer: load commit related config

From: Phillip Wood <phillip.wood@talktalk.net>
Date: Nov 24, 2017, 14:38 UTC
Message-ID: <33de5245-828b-dca3-0b2e-13e54299a6bb@talktalk.net>
In-Reply-To: <xmqqbmjrn5yb.fsf@gitster.mtv.corp.google.com>

On 24/11/17 13:48, Junio C Hamano wrote:

Show 12 quoted lines

> Phillip Wood <phillip.wood@talktalk.net> writes:
> 
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>> Load default values for message cleanup and gpg signing of commits in
>> preparation for committing without forking 'git commit'. Note that we
>> interpret commit.cleanup=scissors to mean COMMIT_MSG_CLEANUP_SPACE to
>> be consistent with 'git commit'
> 
> Hmph, is that because we never invoke the editor to edit the commit
> log message?  Over there, scissors is demoted to space when the
> editor is not in use, but otherwise this demotion does not occur.

Yes that's right. In fact I'm fairly we always specify an explicit cleanup mode when calling try_to_commit() so the default is there in case that changes in the future.

Show 10 quoted lines

> Just being curious.
> 
>>
>> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
>> ---
>>
>> Notes:
>>     changes since v3:
>>      - interpret commit.cleanup=scissors to mean COMMIT_MSG_CLEANUP_SPACE
>>        to match 'git commit'