Re: [PATCH v1 3/8] commit: move post-rewrite code to libgit

From: Phillip Wood <phillip.wood@talktalk.net>
Date: Nov 7, 2017, 14:28 UTC
Message-ID: <a3d29ea7-1939-1595-0978-08a418b2b324@talktalk.net>
In-Reply-To: <xmqqpo8ug587.fsf@gitster.mtv.corp.google.com>

On 07/11/17 03:03, Junio C Hamano wrote:

Show 13 quoted lines

> Phillip Wood <phillip.wood@talktalk.net> writes:
> 
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>> Move run_rewrite_hook() from bulitin/commit.c to sequencer.c so it can
>> be shared with other commands and add a new function
>> commit_post_rewrite() based on the code in builtin/commit.c that
>> encapsulates rewriting notes and running the post-rewrite hook.
> 
> This, especially the part that rips out the notes rewriting from
> builtin/commit.c and moves it to elsewhere, is a bit curious
> separation of labor.  I guess we'll see why in later steps in the
> series.

It's so the sequencer can have a built in version of 'git commit --amend' when processing fixup/squash commands. I'll expand the commit message to explain why this is needed later.

> The change itself looks like a regression-free no-op, which is good.
>