Re: [PATCH v3 18/22] builtin/format-patch: fix various trivial memory leaks

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 13, 2024, 16:55 UTC
Message-ID: <xmqqa5hg746o.fsf@gitster.g>
In-Reply-To: <c048b54a2c493658b2dd256b301491a79cfa99a1.1723540931.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> There are various memory leaks hit by git-format-patch(1). Basically all
> of them are trivial, except that un-setting `diffopt.no_free` requires
> us to unset the `diffopt.file` because we manually close it already.

Ah, I misread the patch. Clearly diffopt.file is about double-closing. Makes sense.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.