Re: [PATCH v2 00/22] Memory leak fixes (pt.4)

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 12, 2024, 15:50 UTC
Message-ID: <xmqq7ccl7nav.fsf@gitster.g>
In-Reply-To: <4dbf731a-873b-4cab-b8ff-745bfa059060@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 18 quoted lines

> On 08/08/2024 14:04, Patrick Steinhardt wrote:
>> Hi,
>> this is the second version of my fourth batch of patches that fix
>> various memory leaks.
>> Changes compared to v1:
>>    - Adapt the memory leak fix for command characters to instead use
>> a
>>      `comment_line_str_allocated` variable.
>>    - Clarify some commit messages.
>>    - Drop the TODO comment about `rebase.gpgsign`. Turns out that
>> this is
>>      working as intended, as explained by Phillip.
>
> The changes to the rebase and sequencer patches look good to me
>
> Thanks
>
> Phillip

Thanks for a review.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.