Re: [PATCH v2 12/22] builtin/fast-export: fix leaking diff options

From: karthik nayak <karthik.188@gmail.com>
Date: Aug 12, 2024, 09:05 UTC
Message-ID: <CAOLa=ZSPtce9WFCyxDP5Ct7Geqj-g5Q=zfi1R3-kcs5Ms8-7YA@mail.gmail.com>
In-Reply-To: <fa2d5c5d6b7b9018c3271a3c955852d1aeaf44d9.1723121979.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Before caling `handle_commit()` in a loop, we set `diffopt.no_free` such

s/caling/calling

Show 6 quoted lines

> that its contents aren't getting freed inside of `handle_commit()`. We
> never unset that flag though, which means that it'll ultimately leak
> when calling `release_revisions()`.
>
> Fix this by unsetting the flag after the loop.
>

[snip]

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.