Re: [PATCH v3 21/22] diff: free state populated via options

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 13, 2024, 16:31 UTC
Message-ID: <xmqqv80475b2.fsf@gitster.g>
In-Reply-To: <d5cb4ad580c7370a4ee48d2f5075a1764972c353.1723540931.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> The `objfind` and `anchors` members of `struct diff_options` are
> populated via option parsing, but are never freed in `diff_free()`. Fix
> this to plug those memory leaks.

Thanks.

Even though "diff" is generally my bailiwick, I've never paid attention to these features (hence the resources they consume and leak). The patch looks good to me.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.