Re: [PATCH v2 00/22] Memory leak fixes (pt.4)
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Aug 13, 2024, 06:27 UTC
- Message-ID
- <Zrr8wmYpY02lM19k@tanuki>
- In-Reply-To
- <xmqqbk1x7nbs.fsf@gitster.g>
On Mon, Aug 12, 2024 at 08:49:59AM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> karthik nayak <karthik.188@gmail.com> writes: > > > I went through the series and apart from some typos, everything looked > > great. I don't expect a reroll for those typos though, since they're > > minor. > > Thanks for a review. A final reroll that shows only the typofixes > in interdiff/range-diff is not a huge burden, but having to deal > with many separate "here is a typo", "here is another typo" patches > over a period is annoying and it is even worse that many readers > have to get their reading distracted when seeing these leftover > typoes, and get annoyed but yet not annoyed seriously enough to send > these typofix patches to leave them unfixed to cause other readers' > reading hiccupped. Let's always remember that there are 100x more > readers than those of us who write.
Clue taken, I'll finally bite the bullet and set up spell correction in my editor. I'll also reroll this series later today.
Patrick