From: Junio C Hamano Date: Tue, 13 Aug 2024 16:55:43 GMT Subject: Re: [PATCH v3 18/22] builtin/format-patch: fix various trivial memory leaks Message-ID: In-Reply-To: Patrick Steinhardt writes: > There are various memory leaks hit by git-format-patch(1). Basically all > of them are trivial, except that un-setting `diffopt.no_free` requires > us to unset the `diffopt.file` because we manually close it already. Ah, I misread the patch. Clearly diffopt.file is about double-closing. Makes sense.